Extending test timeout for JS Extensions#1446
Open
aaronpowell wants to merge 1 commit into
Open
Conversation
On Windows, during local testing, these resources took a lot longer to start than expected, so extending the timeout
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1446Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1446" |
Contributor
There was a problem hiding this comment.
Pull request overview
Extends the startup/readiness wait timeout in the JavaScript Extensions integration test to accommodate slower resource startup (notably observed on Windows) when validating example apps in the Aspire distributed app host.
Changes:
- Increased the
WaitForResourceHealthyAsync(...).WaitAsync(...)timeout from 5 minutes to 10 minutes for the JavaScript ExtensionsAppHostTestsreadiness check.
Show a summary per file
| File | Description |
|---|---|
| tests/CommunityToolkit.Aspire.Hosting.JavaScript.Extensions.Tests/AppHostTests.cs | Increases the resource health wait timeout used by the JavaScript Extensions AppHost integration test. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Low
| var httpClient = fixture.CreateHttpClient(appName); | ||
|
|
||
| await fixture.ResourceNotificationService.WaitForResourceHealthyAsync(appName).WaitAsync(TimeSpan.FromMinutes(5)); | ||
| await fixture.ResourceNotificationService.WaitForResourceHealthyAsync(appName).WaitAsync(TimeSpan.FromMinutes(10)); |
Contributor
|
aaronpowell
temporarily deployed
to
azure-artifacts
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, during local testing, these resources took a lot longer to start than expected, so extending the timeout
Closes #<ISSUE_NUMBER>
PR Checklist
Other information